Repository navigation
benchmark: merge crc32c into crc32 zlib benchmark - #67004
Merged
Merged
Conversation
Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
lpinca
approved these changes
Oct 28, 2026
trivikr
added
author ready
nodejs-github-bot
added
the
lacks-second-approval
Collaborator
|
Landed in 2758c59 |
nodejs-github-bot
removed
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmark/zlib/crc32c.jswas a copy ofbenchmark/zlib/crc32.jsthat called a different function.This removes it and adds an
algorithmoption (crc32,crc32c) tocrc32.js, so a single run benchmarks both checksums side by side.Refs: #66828